Skip to content

Conversation

@aadamgough
Copy link
Contributor

Summary

Add list manipulation in sharepoint (get list, create list, update list)

Type of Change

  • Other: ___________

Testing

Tested create list, read list, and update list

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

@vercel
Copy link

vercel bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Sep 18, 2025 2:21am
sim Error Error Sep 18, 2025 2:21am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds comprehensive SharePoint list manipulation capabilities to the existing SharePoint integration. The changes introduce three new tools - get_list, create_list, and update_list - that enable users to perform CRUD operations on SharePoint lists through the workflow system.

The implementation extends the SharePoint block with new operations and form fields, adds the necessary OAuth scopes (Sites.Manage.All) for list management permissions, and creates dedicated tool configurations following the established patterns in the codebase. The get_list tool supports listing all lists in a site, retrieving specific list metadata, and fetching list items with pagination. The create_list tool enables programmatic list creation with custom column definitions via JSON. The update_list tool allows modifying list items while filtering out read-only system fields.

All three tools integrate with the existing Microsoft Graph API authentication infrastructure and follow the same architectural patterns as other tools in the registry. The changes include proper type definitions in the SharePoint types file, extending the existing interfaces with new data structures for lists, columns, and list items. The SharePoint block UI is enhanced with conditional field display based on the selected operation, supporting the different parameter requirements for each list operation.

Confidence score: 2/5

  • This PR has significant implementation issues that could cause runtime failures and require careful review
  • Score reflects multiple critical bugs including undefined parameter references, missing error handling, and type safety issues across several files
  • Pay close attention to get_list.ts, update_list.ts, and sharepoint.ts which contain the most problematic code patterns

8 files reviewed, 12 comments

Edit Code Review Bot Settings | Greptile

finalUrl: finalItemsUrl,
siteId,
listId: params.listId,
listTitle: params.listTitle,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Logging undefined listTitle parameter that doesn't exist in schema.

@icecrasher321 icecrasher321 merged commit d0b6945 into staging Sep 18, 2025
4 of 6 checks passed
@aadamgough aadamgough deleted the improvement/sharepoint branch September 18, 2025 20:32
Acumen-Desktop pushed a commit to Acumen-Desktop/sim that referenced this pull request Sep 20, 2025
…ioai#1369)

* added list tools

* not working yet

* improved read and create

* added scopes

* updated sharepoint tools

* added greptile comments

---------

Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants